Skip to content

feat!: Export controls and sequences as dict of arrays #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat!: Export controls and sequences as dict of arrays #289

merged 2 commits into from
Feb 6, 2024

Conversation

@abenseny
Copy link
Member

@abenseny abenseny commented Feb 5, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Export controls and decoupling sequences as dictionaries with arrays, to be compatible with the Q-CTRL Visualizer 7.0.0.
  • Tweak and rerun example notebooks with latest Visualizer version.

BREAKING CHANGE: DrivenControl.export and DynamicDecouplingSequence.export now export each item as a dictionary of arrays (rather than a list of dictionaries).

@abenseny abenseny marked this pull request as ready for review February 5, 2024 03:33
@abenseny abenseny requested a review from a team February 5, 2024 03:33
leoadec
leoadec approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@leoadec leoadec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks Albert!

tachikoma-li
tachikoma-li approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@tachikoma-li tachikoma-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abenseny abenseny merged commit 9898395 into master Feb 6, 2024
@abenseny abenseny deleted the export_format branch February 6, 2024 03:16
@charmasaur
Copy link
Contributor

charmasaur commented Feb 6, 2024

Good call... I apologise for insisting on list-of-dicts for so long, it's one of my big regrets!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoadec leoadec leoadec approved these changes

@tachikoma-li tachikoma-li tachikoma-li approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abenseny @charmasaur @leoadec @tachikoma-li